Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Ajax: better responseText copy logic

#41

Ensure responseText is only copied if it will be used in onInteractive or the readyState is 4 (complete). This keeps aborted/timedout request's footprint down.

Reported by Mark Caudill · July 9th, 2009 @ 11:52 PM

State: resolved
Milestone: none
Assigned to: Mark Caudill Mark Caudill

Activity

  1. Mark Caudill
    Mark Caudill

    July 9th, 2009 @ 11:53 PM

  2. Mark Caudill
    Mark Caudill
    • Tag changed from ajax to ajax, patched

    July 10th, 2009 @ 01:26 PM

  3. John-David Dalton
    John-David Dalton

    Resolved by https://github.com/jdalton/fusejs/commit/6f46946ada5bbe34bc78015bd90e9a0d0175d6b7

    By ensuring each state is called only 1 time and only setting responseText in 3 and 4 we reduce the memory issue.

    We still need to evaluate it because of global responders that could be attached.
    checking those and the request callacks might be an option if the problem persists after this patch.

    August 3rd, 2009 @ 02:43 AM

  4. John-David Dalton
    John-David Dalton
    • State changed from new to resolved

    August 3rd, 2009 @ 02:50 AM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.