Correct Offset methods in FuseJS
Reported by Joe Gornick | February 9th, 2009 @ 12:08 AM
We need to correct the offset code in Fuse. We can use jQuery as a guide to get this started and then compare it to Garrett Smiths code.
Garrett's Code: http://dhtmlkitchen.com/ape/docs/ape-ep-dom.src.html (starting at line 1224)
jQuery's offset code was primarily worked on by Brandon Aaron (gtalk brandon.aaron@gmail.com) who basically through things at the code until it worked (a lot of trail and error)
Joe's very old WIP https://gist.github.com/6623a88b...
Comments and changes to this ticket
-
John-David Dalton July 3rd, 2009 @ 05:48 PM
- Milestone cleared.
-
John-David Dalton July 10th, 2009 @ 08:38 PM
- Title changed from Optimize element offset code to Correct Offset methods in FuseJS
-
Mark Caudill August 5th, 2009 @ 06:03 PM
- Assigned user changed from Joe Gornick to Mark Caudill
- State changed from new to open
- Tag set to discuss
https://gist.github.com/03a0ac3456e2399ea3dd - some starting code mostly adapted from Garrett Smith's APE offset code. If anyone has suggestions, comments, concerns or anything this is a very important ticket so please be vocal.
-
Mark Caudill September 4th, 2009 @ 09:06 AM
- Tag changed from discuss to patched, testing
- State changed from open to patched
I made a commit with the getCoords method. The unit tests are pretty all-encompassing, so give them a test in as many environments as we can to ensure that the data is accurate. One or two errors is to be expected as these were ones that were ignored in APE's unit testing. I believe that things should just work, but report any errors you can.
Commit:
https://github.com/ninjainvisible/fusejs/commit/14ca386621d5b13864f... -
John-David Dalton June 9th, 2010 @ 01:43 PM
- Assigned user changed from Mark Caudill to John-David Dalton
-
Joe Gornick September 29th, 2010 @ 09:33 AM
- Milestone cleared.
- Milestone order changed from 0 to 0
-
Joe Gornick March 22nd, 2011 @ 09:24 PM
- Tag cleared.
- State changed from patched to new
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
JavaScript frameworks share similar features and functionality such as DOM manipulation, event registration, and CSS selector engines. FuseJS attempts to incorporate the strengths of these frameworks into one stable, efficient, and optimized core JavaScript framework.