Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

Correct Offset methods in FuseJS

#20

We need to correct the offset code in Fuse. We can use jQuery as a guide to get this started and then compare it to Garrett Smiths code.

Garrett's Code: http://dhtmlkitchen.com/ape/docs/ape-ep-dom.src.html (starting at line 1224)

jQuery's offset code was primarily worked on by Brandon Aaron (gtalk brandon.aaron@gmail.com) who basically through things at the code until it worked (a lot of trail and error)

Joe's very old WIP https://gist.github.com/6623a88b...

Reported by Joe Gornick · February 9th, 2009 @ 12:08 AM

State: new
Milestone: none
Assigned to: John-David Dalton John-David Dalton

Activity

  1. John-David Dalton
    John-David Dalton
    • Milestone cleared.

    July 3rd, 2009 @ 05:48 PM

  2. John-David Dalton
    John-David Dalton
    • Title changed from Optimize element offset code to Correct Offset methods in FuseJS

    July 10th, 2009 @ 08:38 PM

  3. John-David Dalton
    John-David Dalton

    July 10th, 2009 @ 08:43 PM

  4. Mark Caudill
    Mark Caudill
    • Assigned user changed from Joe Gornick to Mark Caudill
    • State changed from new to open
    • Tag set to discuss

    https://gist.github.com/03a0ac3456e2399ea3dd - some starting code mostly adapted from Garrett Smith's APE offset code. If anyone has suggestions, comments, concerns or anything this is a very important ticket so please be vocal.

    August 5th, 2009 @ 06:03 PM

  5. Mark Caudill
    Mark Caudill
    • Tag changed from discuss to patched, testing
    • State changed from open to patched

    I made a commit with the getCoords method. The unit tests are pretty all-encompassing, so give them a test in as many environments as we can to ensure that the data is accurate. One or two errors is to be expected as these were ones that were ignored in APE's unit testing. I believe that things should just work, but report any errors you can.

    Commit:
    https://github.com/ninjainvisible/fusejs/commit/14ca386621d5b13864f...

    September 4th, 2009 @ 09:06 AM

  6. John-David Dalton
    John-David Dalton
    • Assigned user changed from Mark Caudill to John-David Dalton

    June 9th, 2010 @ 01:43 PM

  7. Joe Gornick
    Joe Gornick
    • Milestone cleared.
    • Milestone order changed from 0 to 0

    September 29th, 2010 @ 09:33 AM

  8. Joe Gornick
    Joe Gornick
    • Tag cleared.
    • State changed from patched to new

    March 22nd, 2011 @ 09:24 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.